Simplify Netty library generic signature#16011
Merged
trask merged 5 commits intoopen-telemetry:mainfrom Jan 28, 2026
Merged
Conversation
42 tasks
trask
force-pushed
the
simplify-generic
branch
from
14d1adf to
7a8705a
Compare
trask
force-pushed
the
simplify-generic
branch
from
d37bd75 to
f5b8e1b
Compare
laurit
reviewed
Jan 27, 2026
| */ | ||
| public CombinedChannelDuplexHandler< | ||
| ? extends ChannelInboundHandlerAdapter, ? extends ChannelOutboundHandlerAdapter> | ||
| public CombinedChannelDuplexHandler<ChannelInboundHandlerAdapter, ChannelOutboundHandlerAdapter> |
Contributor
There was a problem hiding this comment.
perhaps we should use ChannelInboundHandler and ChannelOutboundHandler instead?
laurit
approved these changes
Jan 27, 2026
trask
force-pushed
the
simplify-generic
branch
from
f73f89a to
0a68f50
Compare
laurit
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And deprecate methods that exposed an internal class (HttpServerResponseBeforeCommitHandler) in their API signatures.