LogbackAppenderInstaller: add doc#16002
Merged
laurit merged 1 commit intoopen-telemetry:mainfrom Jan 28, 2026
Merged
Conversation
github-actions
Bot
added
the
test native
laurit
reviewed
Jan 26, 2026
| // configuration because this code runs during ApplicationEnvironmentPreparedEvent, which occurs | ||
| // before the full Spring application context is available. This is the same approach used by | ||
| // org.springframework.boot.context.logging.LoggingApplicationListener. The | ||
| // evaluateBooleanProperty |
Contributor
There was a problem hiding this comment.
should evaluateBooleanProperty be on a separate line?
trask
approved these changes
Jan 26, 2026
|
|
Member
Author
|
@trask can we add claude to easy cla? |
Member
Author
don't worry - I've disabled the setting |
zeitlinger
force-pushed
the
logback-appender-doc
branch
from
80b0e97 to
36e8197
Compare
Contributor
|
@zeitlinger this PR seems to now include some unrelated changes |
zeitlinger
force-pushed
the
logback-appender-doc
branch
from
36e8197 to
140921f
Compare
Member
Author
fixed |
laurit
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.