SQL summary: simplify jflex and support a couple of more cases#15986
Merged
laurit merged 3 commits intoopen-telemetry:mainfrom Jan 27, 2026
Merged
SQL summary: simplify jflex and support a couple of more cases#15986laurit merged 3 commits intoopen-telemetry:mainfrom
laurit merged 3 commits intoopen-telemetry:mainfrom
Conversation
Add rule to reset operation to none when encountering set operators, allowing each SELECT in a UNION query to be processed independently. This ensures proper table extraction for queries like: SELECT ... FROM t1 UNION SELECT ... FROM t2 UNION SELECT ... FROM t3
laurit
reviewed
Jan 26, 2026
| appendCurrentFragment(); | ||
| if (isOverLimit()) return YYEOF; | ||
| } | ||
| "UNION" | "INTERSECT" | "EXCEPT" | "MINUS" { |
Contributor
There was a problem hiding this comment.
I think you could have something like
select
id,
(select max(foo) from (
select foo from foos
union all
select foo from bars)
)) as foo
from main_table
will we loose main_table because of resetting the operation?
Member
Author
There was a problem hiding this comment.
this test case works, but agree it's a little mysterious
uncovered this issue #16007
will come back here after that is merged and see if I can find a breaking test case, and/or make the behavior clearer
laurit
reviewed
Jan 26, 2026
| setOperation(new Values()); | ||
| appendOperationToSummary("VALUES"); | ||
| } | ||
| if (shouldStartNewOperation()) { |
Contributor
There was a problem hiding this comment.
can VALUES appear without a SELECT or INSERT so that the operation would be none?
Member
Author
There was a problem hiding this comment.
yeah, see this test case
laurit
approved these changes
Jan 27, 2026
This was referenced Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.