Conversation
Co-authored-by: trask <[email protected]>
…ethods Co-authored-by: trask <[email protected]>
Co-authored-by: trask <[email protected]>
…rtz methods Co-authored-by: trask <[email protected]>
Co-authored-by: trask <[email protected]>
Co-authored-by: trask <[email protected]>
Copilot
AI
changed the title
[WIP] Remove deprecated messaging and cloud instrumentation code
Remove deprecated messaging & cloud instrumentation APIs
Jan 20, 2026
trask
reviewed
Jan 20, 2026
- Restored all deprecated AWS Lambda Events 2.2 wrapper classes - Restored deprecated methods in IgnoredTypesConfigurer - Restored deprecated methods in InstrumentationModule - Restored deprecated methods in OpenTelemetrySdkAccess Co-authored-by: trask <[email protected]>
Copilot
AI
changed the title
Remove deprecated messaging & cloud instrumentation APIs
Remove deprecated messaging & cloud instrumentation APIs (excluding AWS Lambda Events 2.2 and javaagent extension APIs)
Jan 20, 2026
trask
approved these changes
Jan 20, 2026
Member
|
@copilot fix :instrumentation:aws-sdk:aws-sdk-2.2:library:compileJava |
Update Javadoc to reference createExecutionInterceptor() instead of the removed newExecutionInterceptor() method Co-authored-by: trask <[email protected]>
Contributor
Author
Member
|
@copilot fix :instrumentation:nats:nats-2.17:library:compileJava |
Update Javadoc to reference createConnection() instead of the removed newConnection() methods Co-authored-by: trask <[email protected]>
Contributor
Author
Member
|
@copilot fix Task :instrumentation:kafka:kafka-clients:kafka-clients-2.6:library:testDeprecated failed and run ./gradlew spotlessApply |
- Removed testDeprecated and testDeprecatedSuppressReceiveSpans tasks since the deprecated test classes were removed - Removed excludeTestsMatching filter that was excluding deprecated tests - Applied spotless formatting fixes Co-authored-by: trask <[email protected]>
Contributor
Author
Fixed in commit 6720a49:
|
trask
approved these changes
Jan 22, 2026
laurit
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removal of Deprecated Messaging & Cloud Instrumentation Code
This PR removes deprecated methods and classes across messaging, cloud, and RPC instrumentation modules scheduled for removal in the next major release.
Phase 1: Core API - Messaging & Instrumenter ✅
getMessagePayloadSize()fromMessagingAttributesGetter(instrumentation-api-incubator)getMessagePayloadCompressedSize()fromMessagingAttributesGetter(instrumentation-api-incubator)setSpanNameExtractor()fromInstrumenterCustomizer(instrumentation-api-incubator)setSpanStatusExtractor()fromInstrumenterCustomizer(instrumentation-api-incubator)Phase 2: Kafka & JMS Messaging ✅
TracingConsumerInterceptorclass (kafka-clients-2.6)TracingProducerInterceptorclass (kafka-clients-2.6)setMessagingReceiveInstrumentationEnabled()fromKafkaInstrumenterFactory(kafka-clients-common-0.11)setMessagingReceiveInstrumentationEnabled()fromJmsInstrumenterFactory(jms-common)setMessagingReceiveInstrumentationEnabled()fromSpringKafkaTelemetryBuilder(spring-kafka-2.7)Phase 3: Spring Integration & RocketMQ ✅
newChannelInterceptor()fromSpringIntegrationTelemetrynewTracingConsumeMessageHook()fromRocketMqTelemetrynewTracingSendMessageHook()fromRocketMqTelemetryPhase 4: NATS ✅
newConnection(Options)fromNatsTelemetrynewConnection(Options.Builder)fromNatsTelemetryNatsTelemetryPhase 5: AWS SDK & Lambda ✅
newRequestHandler()fromAwsSdkTelemetry(1.11)setMessagingReceiveInstrumentationEnabled()fromAwsSdkTelemetryBuilder(1.11)newExecutionInterceptor()fromAwsSdkTelemetry(2.2)setMessagingReceiveInstrumentationEnabled()fromAwsSdkTelemetryBuilder(2.2)AwsSdkTelemetry(2.2)Remove AWS Lambda Events 2.2 wrapper classes(Reverted per feedback)Phase 6: gRPC & Dubbo (RPC) ✅
newClientInterceptor()fromGrpcTelemetrynewServerInterceptor()fromGrpcTelemetrysetClientSpanNameExtractor()fromGrpcTelemetryBuildersetServerSpanNameExtractor()fromGrpcTelemetryBuildersetClientSpanNameExtractor()fromDubboTelemetryBuildersetServerSpanNameExtractor()fromDubboTelemetryBuilderPhase 7: GraphQL, Elasticsearch, Quartz ✅
newInstrumentation()fromGraphQLTelemetry(12.0)newInstrumentation()fromGraphQLTelemetry(20.0)setSpanNameExtractor()fromElasticsearchRest7TelemetryBuildersetSpanNameExtractor()fromQuartzTelemetryBuilderPhase 8: Logback ✅
setCaptureLogstashAttributes()fromOpenTelemetryAppender(logback-appender-1.0)setCaptureLogstashAttributes()fromLoggingEventMapper(logback-appender-1.0)Reverted Changes (Per Feedback)
Remove(Reverted)configure(IgnoredTypesBuilder, ConfigProperties)fromIgnoredTypesConfigurerRemove(Reverted)defaultEnabled(ConfigProperties)fromInstrumentationModuleRemove(Reverted)forceFlush(int, TimeUnit)fromOpenTelemetrySdkAccessRemove AWS Lambda Events 2.2 deprecated wrapper classes(Reverted)Summary
Most deprecated messaging and cloud instrumentation code has been successfully removed. Some items were kept based on reviewer feedback.
Original prompt
Remove Deprecated Messaging & Cloud Instrumentation Code
Affected Modules
Messaging:
kafka-clients-2.6,kafka-clients-common-0.11,jms-common,spring-kafka-2.7,spring-integration-4.1,rocketmq-client-4.8,nats-2.17Cloud Services:
aws-sdk-1.11,aws-sdk-2.2,aws-lambda-events-2.2Other:
grpc-1.6,apache-dubbo-2.7,graphql-java-12.0/20.0,elasticsearch-rest-7.0,quartz-2.0,logback-appender-1.0Core API:
instrumentation-api-incubator(messaging, instrumenter)Javaagent:
javaagent-extension-api,javaagent-bootstrapRemoval Plan
Phase 1: Core API - Messaging & Instrumenter
MessagingAttributesGetter (
instrumentation-api-incubator) - Remove deprecated methods (L39, L45)InstrumenterCustomizer (
instrumentation-api-incubator) - Remove:setSpanNameExtractorCustomizer(UnaryOperator)setSpanStatusExtractorCustomizer(UnaryOperator)Phase 2: Kafka & JMS Messaging
TracingConsumerInterceptor (
kafka-clients-2.6) - Remove entire class → UseKafkaTelemetry#consumerInterceptorConfigProperties()TracingProducerInterceptor (
kafka-clients-2.6) - Remove entire class → UseKafkaTelemetry#producerInterceptorConfigProperties()KafkaInstrumenterFactory (
kafka-clients-common-0.11) - RemovesetCaptureExperimentalSpanAttributes()→ UsesetMessagingReceiveTelemetryEnabled(boolean)JmsInstrumenterFactory (
jms-common) - RemovesetCaptureExperimentalSpanAttributes()→ UsesetMessagingReceiveTelemetryEnabled(boolean)SpringKafkaTelemetryBuilder (
spring-kafka-2.7) - RemovesetCaptureExperimentalSpanAttributes()→ UsesetMessagingReceiveTelemetryEnabled(boolean)Phase 3: Spring Integration & RocketMQ
SpringIntegrationTelemetry - Remove
newChannelInterceptor()→ UsecreateChannelInterceptor()RocketMqTelemetry - Remove:
newConsumeMessageHook()→createConsumeMessageHook()newSendMessageHook()→createSendMessageHook()Phase 4: NATS
NatsTelemetry - Remove:
newConnection(Options)→createConnection(Options, ConnectionFactory)newConnection(Options.Builder)→createConnection(Options.Builder, ConnectionFactory)Phase 5: AWS SDK & Lambda
AwsSdkTelemetry (1.11) - Remove
newRequestHandler()→ UsecreateRequestHandler()AwsSdkTelemetryBuilder (1.11) - Remove
setCaptureExperimentalSpanAttributes()→ UsesetMessagingReceiveTelemetryEnabled(boolean)AwsSdkTelemetry (2.2) - Remove
newExecutionInterceptor()→ UsecreateExecutionInterceptor()AwsSdkTelemetryBuilder (2.2) - Remove
setCaptureExperimentalSpanAttributes()→ UsesetMessagingReceiveTelemetryEnabled(boolean)AWS Lambda Events (2.2) - Remove entire deprecated wrapper classes:
TracingRequestApiGatewayWrapperTracingRequestWrapperTracingSqsEventHandlerTracingSqsEventWrapperTracingSqsMessageHandlerPhase 6: gRPC & Dubbo (RPC)
GrpcTelemetry - Remove:
newClientInterceptor()→createClientInterceptor()newServerInterceptor()→createServerInterceptor()GrpcTelemetryBuilder - Remove:
setClientSpanNameExtractorCustomizer(UnaryOperator)setServerSpanNameExtractorCustomizer(UnaryOperator)DubboTelemetryBuilder - Remove:
setClientSpanNameExtractorCustomizer(UnaryOperator)setServerSpanNameExtractorCustomizer(UnaryOperator)Phase 7: GraphQL, Elasticsearch, Quartz
GraphQLTelemetry (12.0 & 20.0) - Remove
newInstrumentation()→ UsecreateInstrumentation()ElasticsearchRest7TelemetryBuilder - Remove old span name extractor → Use
setSpanNameExtractorCustomizer(Function)QuartzTelemetryBuilder - Remove old span name extractor → Use
setSpanNameExtractorCustomizer(Function)Phase 8: Logback & Javaagent API
OpenTelemetryAppender (
logback-appender-1.0) - RemovesetCaptureCodeAttributes(boolean)→ UsesetCaptureLogstashMarkerAttributes(boolean)LoggingEventMapper (
logback-appender-1.0) - RemovesetCaptureCodeAttributes(boolean)→ UsesetCaptureLogstashMarkerAttributes(boolean)IgnoredTypesConfigurer (
javaagent-extension-api) - Remove old configure method → Useconfigure(IgnoredTypesBuilder)InstrumentationModule (
javaagent-extension-api) - Remove old method → UsedefaultEnabled()(will be removed in 3.0.0)OpenTelemetrySdkAccess (
javaagent-bootstrap) - Remove deprecated memberTesting Strategy
Gradle Test Tasks: