Skip to content

Implement stable database semconv span name#15854

Merged
trask merged 9 commits intoopen-telemetry:mainfrom
trask:db-semconv-span-name
Jan 13, 2026
Merged

Implement stable database semconv span name#15854
trask merged 9 commits intoopen-telemetry:mainfrom
trask:db-semconv-span-name

Conversation

@trask
Copy link
Copy Markdown
Member

@trask trask commented Jan 12, 2026

@github-actions github-actions Bot added the test native This label can be applied to PRs to trigger them to run native tests label Jan 12, 2026
@trask trask force-pushed the db-semconv-span-name branch from 33cda4b to 44a7af5 Compare January 13, 2026 01:35
@trask trask force-pushed the db-semconv-span-name branch from 44a7af5 to e84373c Compare January 13, 2026 01:42
@trask trask force-pushed the db-semconv-span-name branch from 2191bdc to 25d9106 Compare January 13, 2026 04:39
Comment on lines +49 to +53
String operationName = uniqueOperationName.getValue();
return new MultiQuery(
uniqueCollectionName.getValue(),
uniqueStoredProcedureName.getValue(),
uniqueOperationName.getValue(),
operationName == null ? "BATCH" : "BATCH " + operationName,
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved this here from SqlClientAttributesExtractor so I can reuse this value from DbClientSpanNameExtractor

Update span name assertions for stable semconv:
- hibernate-3.3: Use conditional span name in assertClientSpan (without db prefix)
- cassandra-3.0: Fix USE keyspace span name to expect 'cassandra' fallback
  (server.address not available at span start time)
@trask trask marked this pull request as ready for review January 13, 2026 15:05
@trask trask requested a review from a team as a code owner January 13, 2026 15:05
@trask trask merged commit 9a97234 into open-telemetry:main Jan 13, 2026
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test native This label can be applied to PRs to trigger them to run native tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants