Rename new* methods to create* for consistency#15832
Merged
trask merged 1 commit intoopen-telemetry:mainfrom Jan 12, 2026
Merged
Rename new* methods to create* for consistency#15832trask merged 1 commit intoopen-telemetry:mainfrom
new* methods to create* for consistency#15832trask merged 1 commit intoopen-telemetry:mainfrom
Conversation
trask
force-pushed
the
rename-new-to-create
branch
from
16e4e42 to
28b3b7c
Compare
trask
commented
Jan 10, 2026
| * org.apache.rocketmq.client.impl.producer.DefaultMQProducerImpl#registerSendMessageHook(SendMessageHook)}. | ||
| */ | ||
| public SendMessageHook newTracingSendMessageHook() { | ||
| public SendMessageHook createSendMessageHook() { |
Member
Author
There was a problem hiding this comment.
"Tracing" seems redundant and isn't added elsewhere
zeitlinger
approved these changes
Jan 12, 2026
laurit
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #15830
Related to