Declarative config for logback appender installer#15813
Merged
laurit merged 5 commits intoopen-telemetry:mainfrom Jan 22, 2026
Merged
Declarative config for logback appender installer#15813laurit merged 5 commits intoopen-telemetry:mainfrom
laurit merged 5 commits intoopen-telemetry:mainfrom
Conversation
github-actions
Bot
added
the
test native
trask
reviewed
Jan 9, 2026
trask
reviewed
Jan 9, 2026
trask
reviewed
Jan 9, 2026
zeitlinger
force-pushed
the
declarativ-config-for-LogbackAppenderInstaller
branch
from
a8a7561 to
2bbec8a
Compare
Member
Author
|
@trask please have a look |
trask
reviewed
Jan 22, 2026
Comment on lines
86
to
88
| private static void initializeOpenTelemetryAppenderFromProperties( | ||
| ApplicationEnvironmentPreparedEvent applicationEnvironmentPreparedEvent, | ||
| OpenTelemetryAppender openTelemetryAppender) { |
Member
There was a problem hiding this comment.
can you add a comment here explaining what we're doing here (reading directly from spring yaml instead of via declarative configuration) and why?
trask
approved these changes
Jan 22, 2026
laurit
approved these changes
Jan 22, 2026
github-project-automation
Bot
moved this from Awaiting Review
to Done
in Declarative Configuration: Java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #15812