Ensure consistent EarlyInitAgentConfig access#15787
Ensure consistent EarlyInitAgentConfig access#15787trask merged 4 commits intoopen-telemetry:mainfrom
Conversation
2e0cb67 to
e76a917
Compare
|
@trask please check again |
|
hmm, changing the LoggingCustomizer interface breaks our distribution. Not a biggie, I can fix it but isn't this sort of API change a breaking change? |
|
|
|
Making the EarlyInitAgentConfig.getString (and other get*) private is annoying since the property we're looking at ( It's not terrible, I can look for the setting directly, but (and @zeitlinger ) I think for ongoing changes to these to make it ConfigProvider friendly, please check how distributions can use additional options |
Going forward, the ConfigProvider API is meant to be used whenever possible - much like we're already doing it in the agent. A trimmed down version of https://github.com/zeitlinger/opentelemetry-java-instrumentation/blob/79edac70672b2d52bfa35b8b5727b6370e566261/declarative-config-bridge/src/main/java/io/opentelemetry/instrumentation/config/bridge/ConfigPropertiesBackedConfigProvider.java#L18 sholud be added to contrib. If you want, you can do that right now 😄 |
|
Does that help with config before the agent is initialized (which is what EarlyInitAgentConfig is needed for)? |
no it doesn't - maybe you'll have to have your own copy of ConfigPropertiesUtil (which is also going to javaagent-bootstrap in #15809) |
Based on #15761