Convert last AgentInstrumentationConfig usages#15752
Merged
trask merged 1 commit intoopen-telemetry:mainfrom Dec 31, 2025
Merged
Convert last AgentInstrumentationConfig usages#15752trask merged 1 commit intoopen-telemetry:mainfrom
trask merged 1 commit intoopen-telemetry:mainfrom
Conversation
trask
commented
Dec 30, 2025
Comment on lines
-391
to
+395
| String experimentalOverride = | ||
| ConfigPropertiesUtil.getString( | ||
| "otel.instrumentation.experimental.span-suppression-strategy"); | ||
| String result = | ||
| commonConfig.getString( | ||
| "span_suppression_strategy/development", | ||
| experimentalOverride == null ? "" : experimentalOverride); | ||
| ConfigPropertiesUtil.getString( | ||
| "otel.instrumentation.experimental.span-suppression-strategy", "")); |
Member
Author
There was a problem hiding this comment.
this is just a small refactoring to follow newly established pattern
Comment on lines
-294
to
-301
| private static void copyNecessaryConfigToSystemProperties(ConfigProperties config) { | ||
| for (String property : asList("otel.instrumentation.experimental.span-suppression-strategy")) { | ||
| String value = config.getString(property); | ||
| if (value != null) { | ||
| System.setProperty(property, value); | ||
| } | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
this isn't needed anymore now that span_suppression_strategy is read first from declarative config API
| private static final boolean REFLECTION_ENABLED = | ||
| AgentInstrumentationConfig.get() | ||
| .getBoolean("otel.instrumentation.internal-reflection.enabled", true); | ||
| ConfigPropertiesUtil.getBoolean("otel.instrumentation.internal-reflection.enabled", true); |
Member
Author
There was a problem hiding this comment.
this is too early to use DeclarativeConfigUtil
zeitlinger
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.