Migrate runtime-telemetry to use declarative configuration API#15734
Merged
trask merged 2 commits intoopen-telemetry:mainfrom Dec 30, 2025
Merged
Migrate runtime-telemetry to use declarative configuration API#15734trask merged 2 commits intoopen-telemetry:mainfrom
trask merged 2 commits intoopen-telemetry:mainfrom
Conversation
github-actions
Bot
added
the
test native
trask
force-pushed
the
runtime-telemetry
branch
3 times, most recently
from
621f255 to
47c4970
Compare
zeitlinger
reviewed
Dec 27, 2025
| if (config.getBoolean("otel.instrumentation.runtime-telemetry-java17.enable-all", false)) { | ||
| boolean defaultEnabled = | ||
| DeclarativeConfigUtil.getInstrumentationConfig(openTelemetry, "common") | ||
| .getBoolean("default_enabled", true); |
Member
There was a problem hiding this comment.
This is mapped to agent.instrumentaion_mode (or similar) - see declarative config bridge
Member
There was a problem hiding this comment.
Also spring.Instrumentation_mode
Member
Author
| RuntimeMetrics runtimeMetrics = | ||
| RuntimeMetricsConfigUtil.configure( | ||
| RuntimeMetrics.builder(GlobalOpenTelemetry.get()), AgentInstrumentationConfig.get()); | ||
| RuntimeMetrics.builder(GlobalOpenTelemetry.get()), GlobalOpenTelemetry.get()); |
Member
There was a problem hiding this comment.
Kind of redundant to pass otel twice, but I guess it's OK
trask
force-pushed
the
runtime-telemetry
branch
2 times, most recently
from
79388ba to
a7dc153
Compare
trask
commented
Dec 29, 2025
trask
commented
Dec 29, 2025
trask
force-pushed
the
runtime-telemetry
branch
from
a7dc153 to
b8b482b
Compare
zeitlinger
reviewed
Dec 29, 2025
trask
force-pushed
the
runtime-telemetry
branch
from
d71d4f3 to
4f36c8d
Compare
trask
force-pushed
the
runtime-telemetry
branch
from
4f36c8d to
c2522b0
Compare
trask
commented
Dec 29, 2025
zeitlinger
approved these changes
Dec 30, 2025
| @Nullable | ||
| public static RuntimeMetrics configure( | ||
| RuntimeMetricsBuilder builder, InstrumentationConfig config) { | ||
| RuntimeMetricsBuilder builder, OpenTelemetry openTelemetry, String instrumentationMode) { |
Member
There was a problem hiding this comment.
I wonder if a proper enum is warranted here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.