Migrate annotation instrumentation to declarative config API#15732
Merged
trask merged 1 commit intoopen-telemetry:mainfrom Dec 28, 2025
Merged
Migrate annotation instrumentation to declarative config API#15732trask merged 1 commit intoopen-telemetry:mainfrom
trask merged 1 commit intoopen-telemetry:mainfrom
Conversation
trask
force-pushed
the
migrate-external-annotation-config
branch
2 times, most recently
from
002f156 to
ac8cbef
Compare
trask
force-pushed
the
migrate-external-annotation-config
branch
2 times, most recently
from
b901967 to
6aa55ae
Compare
trask
force-pushed
the
migrate-external-annotation-config
branch
from
6aa55ae to
3116823
Compare
trask
commented
Dec 27, 2025
| DeclarativeConfigUtil.getInstrumentationConfig( | ||
| GlobalOpenTelemetry.get(), "opentelemetry_extension_annotations") | ||
| .getString("exclude_methods")); | ||
| GlobalOpenTelemetry.get(), "opentelemetry_extension_annotations")); |
Member
Author
There was a problem hiding this comment.
changed this to support structured list for exclude_methods instead of simply carrying over the encoded string (and added test for it)
trask
commented
Dec 27, 2025
| DeclarativeConfigUtil.getInstrumentationConfig( | ||
| GlobalOpenTelemetry.get(), "opentelemetry_instrumentation_annotations") | ||
| .getString("exclude_methods")); | ||
| GlobalOpenTelemetry.get(), "opentelemetry_instrumentation_annotations")); |
trask
commented
Dec 27, 2025
Comment on lines
+5
to
+8
| exclude_methods: | ||
| - class: io.opentelemetry.test.annotation.TracedWithSpan | ||
| methods: | ||
| - ignored |
Member
Author
There was a problem hiding this comment.
this is the newly supported declarative config format (still falling back to the encoded version for backcompat)
zeitlinger
approved these changes
Dec 27, 2025
| } | ||
|
|
||
| val testDeclarativeConfig by registering(Test::class) { | ||
| testClassesDirs = sourceSets.test.get().output.classesDirs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.