Skip to content

Migrate most of the remaining AgentInstrumentationConfig.get() usages to declarative config API#15722

Merged
trask merged 2 commits intoopen-telemetry:mainfrom
trask:agent-instrumentation-config-2
Dec 24, 2025
Merged

Migrate most of the remaining AgentInstrumentationConfig.get() usages to declarative config API#15722
trask merged 2 commits intoopen-telemetry:mainfrom
trask:agent-instrumentation-config-2

Conversation

@trask
Copy link
Copy Markdown
Member

@trask trask commented Dec 23, 2025

No description provided.

@trask trask force-pushed the agent-instrumentation-config-2 branch from fbe76ac to e89239a Compare December 23, 2025 23:26
@trask trask force-pushed the agent-instrumentation-config-2 branch from e89239a to af7ce6f Compare December 23, 2025 23:33
boolean captureLogstashMarkerAttributes =
DeprecatedConfigProperties.getBoolean(
config,
"otel.instrumentation.logback-appender.experimental.capture-logstash-attributes",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(breaking) removing support for previously deprecated property

@trask trask marked this pull request as ready for review December 24, 2025 05:19
@trask trask requested a review from a team as a code owner December 24, 2025 05:19
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Breaking Change Documentation Required

This PR has been labeled as a breaking change. Please ensure you provide the following information:

Migration Notes Required

Please add detailed migration notes to help users understand:

  • What is changing and why
  • How to update their code/configuration
  • Any alternative approaches if applicable
  • Code examples showing before/after usage

Checklist

  • Migration notes added to the PR description
  • Breaking change is documented in the "Unreleased" section of the Changelog, preferably as part of this PR.
  • Consider if this change requires a major version bump

Your migration notes will be included in the release notes to help users upgrade smoothly. The more detailed and helpful they are, the better the user experience will be.


This comment was automatically generated because the breaking change label was applied to this PR.

@trask trask merged commit cc9034f into open-telemetry:main Dec 24, 2025
88 checks passed
@trask trask deleted the agent-instrumentation-config-2 branch December 24, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants