Migrate CommonConfig to Declarative Configuration API#15707
Merged
trask merged 7 commits intoopen-telemetry:mainfrom Dec 22, 2025
Merged
Migrate CommonConfig to Declarative Configuration API#15707trask merged 7 commits intoopen-telemetry:mainfrom
trask merged 7 commits intoopen-telemetry:mainfrom
Conversation
github-actions
Bot
added
the
test native
trask
commented
Dec 22, 2025
| "otel.instrumentation.common.logging.trace-flags", LoggingContextConstants.TRACE_FLAGS); | ||
| } | ||
|
|
||
| public CommonConfig(OpenTelemetry openTelemetry) { |
Member
Author
There was a problem hiding this comment.
Spring boot starter is still using the other constructor for now
| "otel.instrumentation.common.enduser.scope.enabled", false); | ||
| } | ||
|
|
||
| EnduserConfig(ExtendedDeclarativeConfigProperties commonConfig) { |
Member
Author
There was a problem hiding this comment.
Spring boot starter is still using the other constructor for now
Comment on lines
+32
to
+36
| config.getBoolean("otel.instrumentation.http.client.emit-experimental-telemetry", false); | ||
| if (!urlTemplateEnabled || !config.isDeclarative()) { | ||
| commonConfig | ||
| .get("http") | ||
| .get("client") | ||
| .getBoolean("emit_experimental_telemetry/development", false); |
Member
Author
There was a problem hiding this comment.
moving common http properties under .java.common. node
Comment on lines
39
to
43
| } | ||
| DeclarativeConfigProperties configuration = | ||
| config.getDeclarativeConfig("http").getStructured("client", empty()); | ||
| configuration | ||
| commonConfig | ||
| .get("http") | ||
| .get("client") | ||
| .getStructuredList("url_template_rules", emptyList()) |
zeitlinger
approved these changes
Dec 22, 2025
| generalConfig | ||
| .get("http") | ||
| .get("client") | ||
| .getScalarList("request_captured_headers", String.class, new ArrayList<>()); |
Member
There was a problem hiding this comment.
What about "request", "captured_headers"?
Member
Author
There was a problem hiding this comment.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.