jmx move to internal package + deprecate old API#15658
Merged
trask merged 5 commits intoopen-telemetry:mainfrom Dec 19, 2025
Merged
jmx move to internal package + deprecate old API#15658trask merged 5 commits intoopen-telemetry:mainfrom
trask merged 5 commits intoopen-telemetry:mainfrom
Conversation
…nstrumentation into jmx-deprecate-old-api
SylvainJuge
commented
Dec 16, 2025
| * @deprecated use {@link #addRules(InputStream)} instead | ||
| */ | ||
| // TODO: deprecate this method after 2.23.0 release in favor of addRules | ||
| @Deprecated |
Contributor
Author
There was a problem hiding this comment.
[for reviewer] do we have a way to make sure that we don´t forget to remove those in the future ? Should we create an issue and take care of this in 3.0 ? Those methods have been public and non-deprecated only in two minor releases 2.22.0 and 2.23.0.
Contributor
There was a problem hiding this comment.
You can remove these after the next release. Even if you forget to do it it isn't really a big deal.
laurit
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addClassPathRulesandaddCustomRulesmethods inJmxTelemetryBuilderinternalpackageFixes #14674