Play metadata update and disable controller spans by default#15604
Merged
trask merged 5 commits intoopen-telemetry:mainfrom Dec 11, 2025
Merged
Play metadata update and disable controller spans by default#15604trask merged 5 commits intoopen-telemetry:mainfrom
trask merged 5 commits intoopen-telemetry:mainfrom
Conversation
…mentation into play-metadata
laurit
approved these changes
Dec 11, 2025
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #14096
Also noticed that 2.6 was creating controller spans without checking the configuration option, so I changed that. I can move it to a separate PR if we want, otherwise I can slap the "breaking change" label on here.
Migration notes
Controller spans emitted by Play MVC 2.6 instrumentation are now disabled by default, but can be re-enabled with the configuration option:
otel.instrumentation.common.experimental.controller-telemetry.enabled=true.