feat: Add support for SOFARPC framework#15589
Merged
Merged
Conversation
This PR adds instrumentation support for SOFARPC framework, including: - Javaagent instrumentation module - Library autoconfigure module - Testing utilities and test cases - Support for SOFARPC 5.4.0 through 5.12.0+ Fixes open-telemetry#15496
|
|
steverao
reviewed
Dec 10, 2025
steverao
reviewed
Dec 10, 2025
steverao
reviewed
Dec 10, 2025
steverao
reviewed
Dec 10, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive instrumentation support for the SOFARPC framework, enabling distributed tracing for RPC calls. The implementation includes both javaagent-based auto-instrumentation and library-based manual instrumentation approaches, with full support for synchronous, asynchronous, and generic invocations.
Key changes:
- Adds javaagent instrumentation module with automatic filter injection via SPI
- Adds library autoconfigure module with manual instrumentation API
- Implements comprehensive test coverage including chain tracing, error handling, async calls, and local call detection
- Supports SOFARPC versions 5.4.0 through 5.12.0+
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle.kts | Adds three new subprojects for SOFARPC instrumentation (javaagent, library-autoconfigure, testing) |
| instrumentation/sofa-rpc/metadata.yaml | Defines instrumentation metadata including supported versions, semantic conventions, and configuration options |
| instrumentation/sofa-rpc/testing/build.gradle.kts | Configures test dependencies and runtime classpath with SOFARPC 5.4.0 and compatible logging dependencies |
| instrumentation/sofa-rpc/testing/src/main/java/.../api/* | Defines test service interfaces (HelloService, MiddleService, ErrorService) for testing RPC scenarios |
| instrumentation/sofa-rpc/testing/src/main/java/.../impl/* | Implements test services including error handling, chaining, and timeout scenarios |
| instrumentation/sofa-rpc/testing/src/main/java/.../AbstractSofaRpcTest.java | Provides base test class for synchronous, asynchronous, and error handling test scenarios |
| instrumentation/sofa-rpc/testing/src/main/java/.../AbstractSofaRpcTraceChainTest.java | Tests trace propagation through chained RPC calls and local call filtering |
| instrumentation/sofa-rpc/library-autoconfigure/src/main/java/.../* | Core library instrumentation including telemetry builder, filters, attribute extractors, and context propagation |
| instrumentation/sofa-rpc/library-autoconfigure/src/test/java/.../* | Library instrumentation tests extending abstract test classes |
| instrumentation/sofa-rpc/library-autoconfigure/build.gradle.kts | Configures library dependencies with SOFARPC 5.4.0 and AutoValue for code generation |
| instrumentation/sofa-rpc/library-autoconfigure/src/main/resources/META-INF/services/* | SPI configuration for auto-registering OpenTelemetry filters with SOFARPC |
| instrumentation/sofa-rpc/javaagent/src/main/java/.../* | Javaagent instrumentation module with resource injection and filter delegation |
| instrumentation/sofa-rpc/javaagent/src/testSofaRpc/java/.../* | Javaagent-specific tests with peer service attribute support |
| instrumentation/sofa-rpc/javaagent/build.gradle.kts | Configures javaagent build with muzzle checks for version 5.0.0+ and test suites |
| instrumentation/sofa-rpc/javaagent/src/main/resources/* | SPI configuration for javaagent filter registration |
This PR adds instrumentation support for SOFARPC framework, including: - Javaagent instrumentation module - Library autoconfigure module - Testing utilities and test cases - Support for SOFARPC 5.4.0 through 5.12.0+ Fixes open-telemetry#15496
…va/io/opentelemetry/instrumentation/sofarpc/v5_4/SofaRpcTelemetryBuilder.java Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
steverao
reviewed
Dec 12, 2025
steverao
reviewed
Dec 12, 2025
This PR adds instrumentation support for SOFARPC framework, including: - Javaagent instrumentation module - Library autoconfigure module - Testing utilities and test cases - Support for SOFARPC 5.4.0 through 5.12.0+ Fixes open-telemetry#15496
This PR adds instrumentation support for SOFARPC framework, including: - Javaagent instrumentation module - Library autoconfigure module - Testing utilities and test cases - Support for SOFARPC 5.4.0+ Fixes open-telemetry#15496
This PR adds instrumentation support for SOFARPC framework, including: - Javaagent instrumentation module - Library autoconfigure module - Testing utilities and test cases - Support for SOFARPC 5.4.0+ Fixes open-telemetry#15496
This PR adds instrumentation support for SOFARPC framework, including: - Javaagent instrumentation module - Library autoconfigure module - Testing utilities and test cases - Support for SOFARPC 5.4.0+ Fixes open-telemetry#15496
steverao
reviewed
Dec 15, 2025
This PR adds instrumentation support for SOFARPC framework, including: - Javaagent instrumentation module - Library autoconfigure module - Testing utilities and test cases - Support for SOFARPC 5.4.0+ Fixes open-telemetry#15496
This PR adds instrumentation support for SOFARPC framework, including: - Javaagent instrumentation module - Library autoconfigure module - Testing utilities and test cases - Support for SOFARPC 5.4.0+ Fixes open-telemetry#15496
This PR adds instrumentation support for SOFARPC framework, including: - Javaagent instrumentation module - Library autoconfigure module - Testing utilities and test cases - Support for SOFARPC 5.4.0+ Fixes open-telemetry#15496
fangxiu-wf
marked this pull request as ready for review
December 17, 2025 12:16
jaydeluca
reviewed
Dec 19, 2025
jaydeluca
reviewed
Dec 19, 2025
This PR adds instrumentation support for SOFARPC framework, including: - Javaagent instrumentation module - Library autoconfigure module - Testing utilities and test cases - Support for SOFARPC 5.4.0+ Fixes open-telemetry#15496
laurit
reviewed
Jun 5, 2026
laurit
reviewed
Jun 5, 2026
laurit
reviewed
Jun 5, 2026
laurit
reviewed
Jun 5, 2026
laurit
reviewed
Jun 5, 2026
laurit
reviewed
Jun 5, 2026
laurit
reviewed
Jun 5, 2026
laurit
reviewed
Jun 5, 2026
laurit
reviewed
Jun 5, 2026
laurit
reviewed
Jun 5, 2026
laurit
reviewed
Jun 5, 2026
laurit
reviewed
Jun 5, 2026
…ove duplicate import in SofaRpcTest
laurit
approved these changes
Jun 10, 2026
Contributor
|
Thank you for your contribution @fangxiu-wf! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds instrumentation support for SOFARPC framework, including:
Fixes #15496