fix(akka): improve handling of http.route#15504
Merged
trask merged 5 commits intoopen-telemetry:mainfrom Dec 5, 2025
Merged
Conversation
2032549 to
26be8a0
Compare
26be8a0 to
1a3d820
Compare
laurit
approved these changes
Dec 5, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15503
http.routeattribute at all in some cases. As a result, the span name only encapsulates the HTTP method (e.g.GET).http.routeattribute are neglecting slashes when computing the route. This is reproducible on both JDK11 and JDK21.Following the recommendation on slack, I chose to follow a similar approach to the pekko instrumentation's route capture logic.