Add an option to disable capturing graphql query document#15384
Merged
trask merged 3 commits intoopen-telemetry:mainfrom Nov 21, 2025
Merged
Add an option to disable capturing graphql query document#15384trask merged 3 commits intoopen-telemetry:mainfrom
trask merged 3 commits intoopen-telemetry:mainfrom
Conversation
trask
reviewed
Nov 19, 2025
Comment on lines
-48
to
+50
| attributes.put(GRAPHQL_DOCUMENT, request.getQuery()); | ||
| if (request.getQuery() != null) { | ||
| attributes.put(GRAPHQL_DOCUMENT, request.getQuery()); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
In many places we use AttributesExtractorUtil.internalSet that skips null values. I suspect that the marshaling in sdk does not skip nulls, but didn't verify.
Member
There was a problem hiding this comment.
I think we originally did that because it was previously undocumented behavior, but that changed with open-telemetry/opentelemetry-java#7271, probably we could revisit those places now, but not a priority
jaydeluca
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #15278
Also switches to
AstPrinter.printAstCompactfor constructing the query document.