Use Jackson for telemetry files#15319
Merged
trask merged 4 commits intoopen-telemetry:mainfrom Nov 17, 2025
Merged
Conversation
jaydeluca
commented
Nov 16, 2025
| // We want to ignore test related attributes | ||
| private static final List<String> EXCLUDED_ATTRIBUTES = | ||
| List.of( | ||
| "asdf", |
Member
Author
There was a problem hiding this comment.
trask
reviewed
Nov 16, 2025
Comment on lines
+6903
to
+6909
| - name: kafka.consumer.assigned_partitions | ||
| description: The number of partitions currently assigned to this consumer | ||
| type: DOUBLE_GAUGE | ||
| unit: '' | ||
| attributes: | ||
| - name: client-id | ||
| type: STRING |
Member
There was a problem hiding this comment.
I'm not sure if we should document telemetry that comes from metric bridges like kafka and micrometer?
Member
Author
There was a problem hiding this comment.
i think it is useful to have this information, but I agree that maybe it doesn't fit in this current form. I have created #15333 to dig into this further.
Member
Author
There was a problem hiding this comment.
PR to remove these metrics: #15342
I removed any changes to the instrumentation-list.yaml from this PR, so now it just focuses on improving the parsing
trask
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some parsing issues related to some of the kafka metric descriptions, which needed to be escaped. Rewrote the class that writes the
.telemetryfiles to use jackson.This was the error being fixed: