JMS Jodd HTTP and JSF metadata updates#15212
Conversation
| This instrumentation enables controller spans for Mojarra JSF action listeners (controller spans are disabled by default). | ||
| library_link: https://github.com/eclipse-ee4j/mojarra | ||
| features: | ||
| - CONTROLLER_SPANS |
There was a problem hiding this comment.
besides controller spans jsf instrumentations also update the server span name, but they don't update the route
There was a problem hiding this comment.
i was on the fence about including that detail as a feature, but thinking more about it, i think we should. I think it's useful to know when an instrumentation might impact a server span generated by another instrumentation. I'm going to followup and add a new SERVER_SPAN_NAME feature
There was a problem hiding this comment.
We are a bit inconsistent with this. There are some instrumentations that update just the span name and some that update the route even though the set route won't match what was actually requested (it is questionable whether such usage of route is allowed by spec). Metadata of some jaxws instrumentations also includes HTTP_ROUTE although these also just set the server span name.
There was a problem hiding this comment.
yea, i was just doing some digging and identified cxf, metro, and axis jaxws all fall into this category. I'm going to review more
2 participants
Part of #14096