JAXRS metadata updates#15184
Conversation
| display_name: JAX-RS 1.x | ||
| description: | | ||
| This instrumentation enables spans for JAX-RS methods, and enriches existing HTTP server spans with route information. | ||
| This instrumentation enriches HTTP server spans with route information and enables controller spans for JAX-RS annotated methods (this instrumentation is disabled by default). |
There was a problem hiding this comment.
JAX-RS 2.x uses a slightly different wording controller spans are disabled by default which I think is better
There was a problem hiding this comment.
Actually I don't know this instrumentation is disabled by default is also totally correct, your choice which you wish to use.
There was a problem hiding this comment.
this is where i am getting the "disabled by default" from: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/jaxrs/jaxrs-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v1_0/JaxrsInstrumentationModule.java#L44
Some of these JAX ones just use the controllerTelemetryEnabled flag to disable the instrumenter, while others also use this flag in the defaultEnabled method.
With that being said, you are right that this doesn't follow the pattern used elsewhere, i think it makes sense to switch to controller spans are disabled by default, and just use the disabled_by_default attribute for the other piece
3 participants
Part of #14096