Use UnaryOperator<X> instead of Function<X, X> where it simplifies things#15101
Merged
laurit merged 11 commits intoopen-telemetry:mainfrom Oct 24, 2025
Merged
Use UnaryOperator<X> instead of Function<X, X> where it simplifies things#15101laurit merged 11 commits intoopen-telemetry:mainfrom
laurit merged 11 commits intoopen-telemetry:mainfrom
Conversation
github-actions
Bot
added
the
test native
trask
force-pushed
the
unary-operator
branch
2 times, most recently
from
87e4f74 to
6c92a1d
Compare
jaydeluca
approved these changes
Oct 23, 2025
Contributor
📋 Deprecation NoticeThis PR has been labeled as a deprecation. Please ensure you provide the following information: 📝 Deprecation Details RequiredPlease add details to help users understand:
📋 Checklist
Your deprecation notes will be included in the release notes to help users prepare for future changes. This comment was automatically generated because the |
Contributor
|
🔧 The result from spotlessApply was committed to the PR branch. |
trask
commented
Oct 23, 2025
| @CanIgnoreReturnValue | ||
| @SuppressWarnings("unchecked") // safe cast from Function to UnaryOperator | ||
| public GrpcTelemetryBuilder setClientSpanNameExtractor( | ||
| Function<SpanNameExtractor<GrpcRequest>, ? extends SpanNameExtractor<? super GrpcRequest>> |
Member
Author
There was a problem hiding this comment.
I think it's ok to simplify these generics, similar to #12858
laurit
reviewed
Oct 24, 2025
laurit
reviewed
Oct 24, 2025
laurit
reviewed
Oct 24, 2025
laurit
approved these changes
Oct 24, 2025
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using UnaryOperator instead of Function<X, X>.
Resolves #14891