Add JDBC URL parsing support for OceanBase, PolarDB and Lindorm#14790
Merged
trask merged 13 commits intoopen-telemetry:mainfrom Oct 9, 2025
Merged
Add JDBC URL parsing support for OceanBase, PolarDB and Lindorm#14790trask merged 13 commits intoopen-telemetry:mainfrom
trask merged 13 commits intoopen-telemetry:mainfrom
Conversation
Change-Id: Ia3b5f6b74b40763c4df7fa0185223575a2c1b068
|
|
github-actions
Bot
added
the
test native
Contributor
|
🔧 The result from spotlessApply was committed to the PR branch. |
steverao
changed the title
steverao
reviewed
Sep 26, 2025
| return DbSystemValues.CLICKHOUSE; | ||
| case "oceanbase": // Oceanbase | ||
| return DbSystemValues.OCEANBASE; | ||
| case "polardb": // polarDB |
Contributor
There was a problem hiding this comment.
Suggested change
| case "polardb": // polarDB | |
| case "polardb": // PolarDB |
steverao
reviewed
Sep 26, 2025
| return DbSystemValues.OCEANBASE; | ||
| case "polardb": // polarDB | ||
| return DbSystemValues.POLARDB; | ||
| case "lindorm": // lindorm |
Contributor
There was a problem hiding this comment.
Suggested change
| case "lindorm": // lindorm | |
| case "lindorm": // Lindorm |
steverao
reviewed
Sep 26, 2025
| }, | ||
| /** | ||
| * <a | ||
| * href="https://www.alibabacloud.com/help/en/lindorm/user-guide/view-endpoints?spm=a2c63.p38356.help-menu-172543.d_2_0_1.7a1e41feMntzyJ">Driver |
Contributor
There was a problem hiding this comment.
Suggested change
| * href="https://www.alibabacloud.com/help/en/lindorm/user-guide/view-endpoints?spm=a2c63.p38356.help-menu-172543.d_2_0_1.7a1e41feMntzyJ">Driver | |
| * href="https://www.alibabacloud.com/help/en/lindorm/user-guide/view-endpoints">Driver |
Contributor
There was a problem hiding this comment.
deleted
did you forget to actually delete the url parameters?
steverao
reviewed
Sep 26, 2025
|
|
||
| private static Stream<Arguments> oceanbaseArguments() { | ||
| return args( | ||
| // https://docs.aws.amazon.com/secretsmanager/latest/userguide/retrieving-secrets_jdbc.html |
|
|
||
| private static Stream<Arguments> lindormArguments() { | ||
| return args( | ||
| // https://docs.aws.amazon.com/secretsmanager/latest/userguide/retrieving-secrets_jdbc.html |
Change-Id: I39d2ce579c60d5afa2e792f3296eef5d0b495443
…r' into feature/additonal-jdbc-url-parser Change-Id: I5b6ee06da60fc32dc1edece63948d228c95f710b
laurit
reviewed
Sep 29, 2025
Comment on lines
+924
to
+926
| if (subtype.equals(DbSystemValues.ORACLE)) { | ||
| builder.system(DbSystemValues.ORACLE); | ||
| } |
Contributor
There was a problem hiding this comment.
initially I though that it is weird to have subtype and system set to the same value but DATADIRECT url handling does the same
Contributor
Author
There was a problem hiding this comment.
Yes, I've referred to DATADIRECT
laurit
reviewed
Sep 29, 2025
| return GENERIC_URL_LIKE.doParse(clickhouseUrl, builder); | ||
| } | ||
| }, | ||
| /** jdbc:oceanbase://host:port/dbname jdbc:oceanbase:oracle://host:port/dbname */ |
Contributor
There was a problem hiding this comment.
perhaps change the comment to
/**
* Sample urls:
*
* <ul>
* <li>jdbc:oceanbase://host:port/dbname
* <li>jdbc:oceanbase:oracle://host:port/dbname
* </ul>
*/
Contributor
|
🔧 The result from spotlessApply was committed to the PR branch. |
Change-Id: Ic7a1bdab51668642fb2c3e4b775ce30f4e1a841c
…r' into feature/additonal-jdbc-url-parser Change-Id: I6205bbedb81199c2bded7b78112389ca0b935636
Contributor
|
🔧 The result from spotlessApply was committed to the PR branch. |
laurit
approved these changes
Oct 9, 2025
Contributor
|
Thank you for your contribution @pepeshore! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved #14702