Added RPC metrics collection for Apache Dubbo#14690
Merged
laurit merged 5 commits intoopen-telemetry:mainfrom Sep 19, 2025
Merged
Added RPC metrics collection for Apache Dubbo#14690laurit merged 5 commits intoopen-telemetry:mainfrom
laurit merged 5 commits intoopen-telemetry:mainfrom
Conversation
Contributor
|
Maybe there is a clear statement somewhere in semconv specifications, but I think there is a general pattern to capture all durations with seconds as unit, those related issues/PRs might be used as examples of this: |
Contributor
Changing the unit would be a backwards incompatible change. We could add a task for 3.0 to change the unit for the rpc duration metrics. |
trask
reviewed
Sep 18, 2025
trask
approved these changes
Sep 18, 2025
laurit
reviewed
Sep 18, 2025
laurit
approved these changes
Sep 19, 2025
mznet
pushed a commit
to mznet/opentelemetry-java-instrumentation
that referenced
this pull request
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved #14611