Instrument instrumentation suppression api#14565
Merged
laurit merged 3 commits intoopen-telemetry:mainfrom Sep 3, 2025
Merged
Conversation
jaydeluca
reviewed
Sep 2, 2025
Co-authored-by: Jay DeLuca <[email protected]>
jaydeluca
approved these changes
Sep 2, 2025
Contributor
|
@laurit can you elaborate a bit on why this is needed ? My understanding so far was that when an application was using the API/SDK for manual instrumentation then the agent would bridge it to its own internal SDK, is that still the case ? |
Contributor
Author
yes, this is how it is bridged. |
breedx-splk
reviewed
Sep 2, 2025
Comment on lines
+60
to
+63
| public static boolean methodEnter(@Advice.Argument(0) Runnable runnable) { | ||
| InstrumentationUtil.suppressInstrumentation(runnable); | ||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
Is the return value needed here?
Suggested change
| public static boolean methodEnter(@Advice.Argument(0) Runnable runnable) { | |
| InstrumentationUtil.suppressInstrumentation(runnable); | |
| return true; | |
| } | |
| public static void methodEnter(@Advice.Argument(0) Runnable runnable) { | |
| InstrumentationUtil.suppressInstrumentation(runnable); | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an application using the agent also uses the sdk we shouldn't let the agent collect traces from the sdk.