Skip to content

Remove messaging header normalization#14554

Merged
trask merged 20 commits intoopen-telemetry:mainfrom
AlchemyDing:feature-messaging-header
Apr 17, 2026
Merged

Remove messaging header normalization#14554
trask merged 20 commits intoopen-telemetry:mainfrom
AlchemyDing:feature-messaging-header

Conversation

@AlchemyDing
Copy link
Copy Markdown
Member

resolve issue

@AlchemyDing AlchemyDing requested a review from a team as a code owner August 31, 2025 05:27
@SylvainJuge
Copy link
Copy Markdown
Contributor

As described in the related issue #14502 this is a breaking change, so changing the default behavior should only be applied in 3.0.

I think you should thus split this in two steps:

  • implement the change with an opt-in configuration option, so the default behavior remains the same: what this PR should provide
  • in the next major, toggle the default to this new behavior, remove the configuration option and the now "legacy" behavior. Opening a dedicated issue and adding it the 3.0 milestone so we don't forget about this is recommended.

Here is an example of similar issues/PRs to deal with semconv breaking changes:

@AlchemyDing
Copy link
Copy Markdown
Member Author

As described in the related issue #14502 this is a breaking change, so changing the default behavior should only be applied in 3.0.

I think you should thus split this in two steps:

  • implement the change with an opt-in configuration option, so the default behavior remains the same: what this PR should provide
  • in the next major, toggle the default to this new behavior, remove the configuration option and the now "legacy" behavior. Opening a dedicated issue and adding it the 3.0 milestone so we don't forget about this is recommended.

Here is an example of similar issues/PRs to deal with semconv breaking changes:

@SylvainJuge Thank you for your suggestion. I will make this PR as STEP 1

@otelbot-java-instrumentation
Copy link
Copy Markdown
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

@AlchemyDing AlchemyDing marked this pull request as draft September 2, 2025 02:10
@AlchemyDing AlchemyDing marked this pull request as ready for review September 2, 2025 16:13
@breedx-splk breedx-splk added this to the v3.0.0 milestone Sep 4, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 3, 2025

This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 14 days.

@github-actions github-actions Bot added the stale label Dec 3, 2025
@github-actions github-actions Bot closed this Dec 17, 2025
@jaydeluca jaydeluca reopened this Dec 17, 2025
@github-actions github-actions Bot removed the stale label Dec 17, 2025
@github-actions
Copy link
Copy Markdown
Contributor

This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 14 days.

@github-actions github-actions Bot added the stale label Mar 17, 2026
# Conflicts:
#	instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/MessagingAttributesExtractor.java
#	instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/internal/SemconvStability.java
#	instrumentation/kafka/kafka-clients/kafka-clients-0.11/testing/src/main/java/io/opentelemetry/instrumentation/kafkaclients/common/v0_11/internal/KafkaClientBaseTest.java
#	instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/test/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/WrapperSuppressReceiveSpansTest.java
#	instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/test/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/WrapperTest.java
#	instrumentation/pulsar/pulsar-2.8/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/pulsar/v2_8/AbstractPulsarClientTest.java
#	instrumentation/rocketmq/rocketmq-client-4.8/testing/src/main/java/io/opentelemetry/instrumentation/rocketmqclient/v4_8/AbstractRocketMqClientTest.java
#	instrumentation/rocketmq/rocketmq-client-5.0/javaagent/src/test/java/io/opentelemetry/instrumentation/rocketmqclient/v5_0/AbstractRocketMqClientTest.java
#	instrumentation/spring/spring-rabbit-1.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/rabbit/v1_0/SpringRabbitMqTest.java
@github-actions github-actions Bot removed the stale label Mar 29, 2026
@AlchemyDing AlchemyDing marked this pull request as draft March 30, 2026 11:32
@AlchemyDing AlchemyDing marked this pull request as ready for review March 30, 2026 11:32
AlchemyDing and others added 5 commits April 10, 2026 19:42
# Conflicts:
#	instrumentation/aws-sdk/aws-sdk-2.2/testing/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2SqsTracingTest.java
@laurit laurit modified the milestones: v3.0.0, v2.27.0 Apr 16, 2026
@trask trask merged commit 921aa9a into open-telemetry:main Apr 17, 2026
177 of 179 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove messaging header normalization

6 participants