Skip to content

Avoid failures on spring boot 4-m1#14420

Merged
trask merged 2 commits into
open-telemetry:mainfrom
laurit:spring-boot-4-failure
Aug 14, 2025
Merged

Avoid failures on spring boot 4-m1#14420
trask merged 2 commits into
open-telemetry:mainfrom
laurit:spring-boot-4-failure

Conversation

@laurit

@laurit laurit commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

Resolves #14363
A bunch of classes move to different package in spring boot 4. This will hopefully avoid class loading exceptions, but the instrumentations will not function with boot 4.

@laurit
laurit requested a review from a team as a code owner August 13, 2025 07:04
@github-actions github-actions Bot added the test native This label can be applied to PRs to trigger them to run native tests label Aug 13, 2025
@zeitlinger

Copy link
Copy Markdown
Member

Great!

We should have at least a unit or integration test.

@laurit

laurit commented Aug 13, 2025

Copy link
Copy Markdown
Contributor Author

We should have at least a unit or integration test.

We usually don't test milestone versions. The intent of this PR is not to offer full support for spring boot m1 but rather to avoid our starter breaking with it. If you so wish you can add the tests and implement the missing functionality, but we could also do it at a later time when spring boot 4 has been released or when there is a release candidate.

@trask
trask merged commit 3ac6d09 into open-telemetry:main Aug 14, 2025
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test native This label can be applied to PRs to trigger them to run native tests

Projects

None yet

4 participants