Skip to content

Fix rxjava context propagation for ObservableFromCallable#14393

Merged
trask merged 12 commits into
open-telemetry:mainfrom
jaydeluca:rxjava-experiment
Aug 12, 2025
Merged

Fix rxjava context propagation for ObservableFromCallable#14393
trask merged 12 commits into
open-telemetry:mainfrom
jaydeluca:rxjava-experiment

Conversation

@jaydeluca

@jaydeluca jaydeluca commented Aug 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #14382

When using Observable.fromCallable() with different schedulers (.subscribeOn()/.observeOn()), the context was not being propagated to the callable execution.

ObservableFromCallable is an internal class with a private callable, so I needed to do some reflection in the wrapper to make it work, but we now intercept and wrap the callable before it gets scheduled.

@jaydeluca
jaydeluca requested a review from a team as a code owner August 7, 2025 20:23
pepeshore
pepeshore reviewed Aug 11, 2025
View reviewed changes
Comment thread ...-2.0/library/src/main/java/io/opentelemetry/instrumentation/rxjava/v2_0/TracingAssembly.java Outdated
Comment thread ...ry/src/main/java/io/opentelemetry/instrumentation/rxjava/v2_0/TracingCallableObservable.java Outdated
@trask

trask commented Aug 12, 2025

Copy link
Copy Markdown
Member

@jaydeluca can you check if the test latest deps failure is related?

HibernateReactiveTest > initializationError FAILED
    java.lang.NoSuchMethodError: 'io.vertx.core.Future io.vertx.core.Context.executeBlocking(io.vertx.core.Handler)'
        at io.opentelemetry.javaagent.instrumentation.hibernate.reactive.v2_0.HibernateReactiveTest.setUp(HibernateReactiveTest.java:78)

> Task :instrumentation:hibernate:hibernate-reactive-1.0:javaagent:hibernateReactive2Test FAILED

@jaydeluca

jaydeluca commented Aug 12, 2025

Copy link
Copy Markdown
Member Author

@jaydeluca can you check if the test latest deps failure is related?

@trask that testlatestDeps is happening on all PRs and I'm able to reproduce on main locally. There was a hibernate-reactive release that pulled in a newer version of vertx and changed some methods we use in our tests, so it should be unrelated to this PR

@trask
trask merged commit 909bd48 into open-telemetry:main Aug 12, 2025
88 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurit laurit laurit approved these changes
+1 more reviewer
@pepeshore pepeshore pepeshore left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Context Propagation not supported In. RxJava

4 participants

@jaydeluca @trask @laurit @pepeshore