spring starter: add thread details instrumentation / configure logging span exporter#14117
Closed
zeitlinger wants to merge 24 commits intoopen-telemetry:mainfrom
Closed
spring starter: add thread details instrumentation / configure logging span exporter#14117zeitlinger wants to merge 24 commits intoopen-telemetry:mainfrom
zeitlinger wants to merge 24 commits intoopen-telemetry:mainfrom
Conversation
github-actions
Bot
added
the
test native
zeitlinger
changed the title
Member
Author
|
@laurit please have a look 😄 |
laurit
reviewed
Jul 10, 2025
laurit
reviewed
Jul 10, 2025
| * This class is internal and is hence not for public use. Its APIs are unstable and can change at | ||
| * any time. | ||
| */ | ||
| @ConditionalOnEnabledInstrumentation(module = "common.thread-details", enabledByDefault = false) |
Contributor
There was a problem hiding this comment.
agent enables this by default
Member
Author
There was a problem hiding this comment.
@trask please check if thread details should be disabled by default
Member
There was a problem hiding this comment.
sorry, I forgot to raise it in semconv meeting, I've added it to next week's agenda so I won't forget
Member
Author
There was a problem hiding this comment.
then it looks like we can leave it as is
zeitlinger
moved this from In Progress
to Awaiting Review
in Declarative Configuration: Java
Contributor
|
🔧 The result from spotlessApply was committed to the PR branch. |
jaydeluca
reviewed
Jul 17, 2025
jaydeluca
approved these changes
Jul 17, 2025
zeitlinger
force-pushed
the
agent-tracer
branch
from
49c66c3 to
ed45c30
Compare
Member
Author
|
@trask can you check again? |
trask
reviewed
Aug 15, 2025
| public class LoggingExporterAutoConfiguration { | ||
|
|
||
| @Bean | ||
| public AutoConfigurationCustomizerProvider loggingOtelCustomizer() { |
Member
There was a problem hiding this comment.
why only traces and not also metrics and logs? (maybe split the debug behavior out into separate PR? I reviewed the thread stuff and it all looks good to me)
Member
Author
There was a problem hiding this comment.
Good idea: I created #14449 for the thread details
This was referenced Aug 16, 2025
zeitlinger
moved this from Awaiting Review
to Blocked
in Declarative Configuration: Java
Member
Author
|
will start over or integrate into #14062 |
github-project-automation
Bot
moved this from Blocked
to Done
in Declarative Configuration: Java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #14449
Part of #14087