Add code attributes for log4j1#13947
Conversation
|
|
|
/easycla |
trask
left a comment
trask
left a comment
There was a problem hiding this comment.
hi @oliver-zhang! can you add tests for this similar to those in log4j2?
Unit tests have been added |
|
hi @oliver-zhang, thanks for your patience, hopefully we should get #13860 merged in the next few days and then you can rebase and update your PR |
# Conflicts: # instrumentation/log4j/log4j-appender-1.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/log4j/appender/v1_2/LogEventMapper.java
| import org.junit.jupiter.params.provider.Arguments; | ||
| import org.junit.jupiter.params.provider.MethodSource; | ||
|
|
||
| @SuppressWarnings("deprecation") // using deprecated semconv |
There was a problem hiding this comment.
[minor] probably not needed anymore
|
Hi @oliver-zhang, there are still a few test failures, for example in |
|
I've implemented the test fixes in oliver-zhang#1, so it should be mostly a matter of merging it to fix the remaining issues. Once this is done @oliver-zhang you should be able to mark it as ready for review and we should be able to merge it once all the checks are passing. |
3 participants
Add the ability to get code attributes for log4j1