Intercept metrics in test runner#13891
Merged
trask merged 5 commits intoopen-telemetry:mainfrom May 29, 2025
Merged
Conversation
…mentation into metric-interceptor
…mentation into metric-interceptor
trask
reviewed
May 29, 2025
jaydeluca
commented
May 29, 2025
|
|
||
| # Remove all .telemetry directories recursively from the project root | ||
| echo "Searching for and removing all .telemetry directories..." | ||
| find . -type d -name ".telemetry" -exec rm -rf {} + |
Member
Author
There was a problem hiding this comment.
@trask - from your question during the SIG meeting:
The {} bit is the placeholder for the exec command. Whatever files are found by find are inserted in place of the brackets. The + means to build up a long list of the found files and call the exec on all of them at once instead of one at a time, like the more traditional -exec {} ; variant.
trask
approved these changes
May 29, 2025
| hs_err_pid* | ||
| replay_pid* | ||
| .attach_pid* | ||
| **/.telemetry* |
Member
There was a problem hiding this comment.
Suggested change
| **/.telemetry* | |
| .telemetry/ |
Member
Author
There was a problem hiding this comment.
there is a directory generated per instrumentation module
Member
There was a problem hiding this comment.
it should work
if you only want to ignore it in the root, it would be different:
/.telemetry/
24 tasks
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we're getting to the fun part...
This PR covers a few changes:
otel.nullaway-conventionsplugin (as recommended here) and addressed all issues raised by it.telemetryfiles within each instrumentation module directoryI wanted to keep this PR small-ish, so I didn't go through and start enabling this for other modules, but I will followup with that.
I am also going to play around with how we might handle situations where different metrics are emitted by different config options (like
-Dotel.semconv-stability.opt-in=database, as an example), and how we might best display that informationRelated to #13468