Skip to content

semconv stable code#13860

Merged
trask merged 101 commits intoopen-telemetry:mainfrom
SylvainJuge:semconv-stable-code
Jun 25, 2025
Merged

semconv stable code#13860
trask merged 101 commits intoopen-telemetry:mainfrom
SylvainJuge:semconv-stable-code

Conversation

@SylvainJuge
Copy link
Copy Markdown
Contributor

@SylvainJuge SylvainJuge commented May 15, 2025 •
edited
Loading

Semconv 1.33.0 brings stable definitions for code.* namespace, which includes the following changes:

  • code.namespace is removed
  • code.function is renamed to code.function.name and needs to include fully-qualified name of the class in addition to the function
  • code.lineno has been renamed code.line.number
  • code.column has been renamed code.column.number
  • code.filepath has been renamed code.file.path

This PR might have to be updated if merged after the update to semconv 1.33.0 is merged first. EDIT: updated after 1.34.0 semconv update

EDIT: the existing code.* semantic conventions are still produced, the stable ones are opt-in by setting the otel.semconv-stability.opt-in config option to include code (only stable) or code/dup (both stable + old).

@SylvainJuge SylvainJuge self-assigned this May 15, 2025
@github-actions github-actions Bot added the test native This label can be applied to PRs to trigger them to run native tests label May 15, 2025
@otelbot-java-instrumentation
Copy link
Copy Markdown
Contributor

otelbot-java-instrumentation Bot commented Jun 16, 2025

🔧 The result from spotlessApply was committed to the PR branch.

@otelbot-java-instrumentation
Copy link
Copy Markdown
Contributor

otelbot-java-instrumentation Bot commented Jun 17, 2025

🔧 The result from spotlessApply was committed to the PR branch.

@SylvainJuge
Copy link
Copy Markdown
Contributor Author

SylvainJuge commented Jun 17, 2025

I have updated this PR to only emit the deprecated semantic convention attributes by default.
Most instrumentation remain tested with unstable attributes, but some (like log appenders) are tested with both.

Using otel.semconv-stability.opt-in configuration allows to opt-in for the new stable semantic conventions with code or code/dup like we have for the database attributes, so it means we could merge this PR without altering the current behavior.

Then, we could then later remove the support for the unstable code attributes when preparing for the 3.0 release.

Is there already an issue that contains a list of breaking changes that we are planning to include in this major release to track progress on their respective implementations ? If no, please let me know and I can create one so we don't forget about this (and also the database semconv).

@trask
Copy link
Copy Markdown
Member

trask commented Jun 18, 2025

Is there already an issue that contains a list of breaking changes that we are planning to include in this major release to track progress on their respective implementations ?

https://github.com/open-telemetry/opentelemetry-java-instrumentation/milestone/41

@trask trask requested a review from JonasKunz June 18, 2025 01:24
@SylvainJuge SylvainJuge mentioned this pull request Jun 18, 2025
Open
@SylvainJuge
Copy link
Copy Markdown
Contributor Author

SylvainJuge commented Jun 18, 2025

Is there already an issue that contains a list of breaking changes that we are planning to include in this major release to track progress on their respective implementations ?

https://github.com/open-telemetry/opentelemetry-java-instrumentation/milestone/41

Thanks, I've opened #14059.

@trask your review status is still "requested change", do you think there are still things to change before we could merge this ?

@trask trask dismissed their stale review June 18, 2025 16:22

stale

trask
trask approved these changes Jun 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Comment thread instrumentation/grails-3.0/javaagent/src/test/java/test/GrailsTest.java Outdated
Comment thread ...esting/src/main/java/io/opentelemetry/instrumentation/jaxrs/AbstractJaxRsHttpServerTest.java Outdated
Comment thread ...esting/src/main/java/io/opentelemetry/instrumentation/jaxrs/AbstractJaxRsHttpServerTest.java Outdated
Comment thread ...esting/src/main/java/io/opentelemetry/instrumentation/jaxrs/AbstractJaxRsHttpServerTest.java Outdated
Comment thread instrumentation/logback/logback-appender-1.0/library/build.gradle.kts
Comment thread instrumentation/rxjava/rxjava-2.0/javaagent/src/test/java/BaseRxJava2WithSpanTest.java Outdated
Comment thread ...in/java/io/opentelemetry/instrumentation/spring/webmvc/boot/AbstractSpringBootBasedTest.java
Comment thread ...in/java/io/opentelemetry/instrumentation/spring/webmvc/filter/AbstractServletFilterTest.java Outdated
@trask trask merged commit d8723a4 into open-telemetry:main Jun 25, 2025
90 of 91 checks passed
@trask
Copy link
Copy Markdown
Member

trask commented Jun 25, 2025

🎉

@SylvainJuge SylvainJuge deleted the semconv-stable-code branch June 25, 2025 07:44
@SylvainJuge SylvainJuge mentioned this pull request Sep 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurit laurit laurit left review comments

@trask trask trask approved these changes

@JonasKunz JonasKunz Awaiting requested review from JonasKunz

Assignees

@SylvainJuge SylvainJuge

Labels

test native This label can be applied to PRs to trigger them to run native tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SylvainJuge @laurit @trask @JonasKunz