jmx add jvm metrics yaml#13392
Conversation
…nstrumentation into jvm-jmx-metrics
|
I tried to refactor the test assertions to only rely on the ones provided by the SDK (using
Overall I think it would be more beneficial if we extend the SDK |
…nstrumentation into jvm-jmx-metrics
…nstrumentation into jvm-jmx-metrics
…nstrumentation into jvm-jmx-metrics
|
All the test infrastructure code changes have been copied to #13597 to make review easier and allow reusing it. |
…nstrumentation into jvm-jmx-metrics
…nstrumentation into jvm-jmx-metrics
…nstrumentation into jvm-jmx-metrics
…nstrumentation into jvm-jmx-metrics
…nstrumentation into jvm-jmx-metrics
…etry/instrumentation/jmx/rules/JvmTargetSystemTest.java Co-authored-by: Jay DeLuca <[email protected]>
jvm.yamlin the JMX library so it can be reused by jmx-scraper in contrib.Part of #13238 with a scope limited to JVM metrics.
~75% of this PR is for adding test infrastructure similar to contrib repository, it has been moved to #13597 separate PR to make review easier.
PR opened as draft, not ready for review nor being merged yet.UPDATE: Now ready to be merged, the test infrastructure code that is included could be reviewed and merged separately with #13597 .
TODOs
jvm.memory.typemetric attribute once jmx metrics with yaml: need ability to post-process some attribute values #13361 is implementedjvm.cpu.timeonce JMX Metrics with yaml: needed unit conversion mechanism #13369 is implemented (optional, can be done as a follow-up PR).jvm.cpu.timeandjvm.cpu.recent_utilization) that might return-1and would thus not fit their semconv definitions.