Note that this issue proposes an attribute (db.statement.error.count) for tracking failed statements in the batch

I didn't see this in the code, did you end up removing it?

Note that this issue proposes an attribute (db.statement.error.count) for tracking failed statements in the batch

I didn't see this in the code, did you end up removing it?

didn't implement it as I couldn't find it in the semconv

oh, got it, the issue proposed the attribute, thanks 👍

@laurit let me know what you think: laurit#408

I'm thinking it's ok to support batches directly in SqlClientAttributesGetter (it will force people to think about it).

The other changes are mainly me re-writing some of the extractor code in the process of trying to make it make sense to me. I'm not sure if I ended up just replacing your complex code with my complex code though 😅.

@laurit let me know what you think: laurit#408

I'm thinking it's ok to support batches directly in SqlClientAttributesGetter (it will force people to think about it).

merged. I also considered this but wasn't sure we want to force the multiple statement handling on all sql instrumentations since jdbc seemed to be the only one that uses it.

The other changes are mainly me re-writing some of the extractor code in the process of trying to make it make sense to me. I'm not sure if I ended up just replacing your complex code with my complex code though 😅.