Demonstration of new getList() method on the TextMapGetter#12581
Closed
jamesmoessis wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
Demonstration of new getList() method on the TextMapGetter#12581jamesmoessis wants to merge 1 commit intoopen-telemetry:mainfrom
jamesmoessis wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
…ttpServletRequestGetter. Implements a test to demonstrate the new W3CBaggagePropagator working with multiple baggage headers (using a locally published version of opentelemetry-api and opentelemetry-context). The TextMapGetter operates on a Jakarta servlet HttpServletRequest, a very common interface used in many servers. This demonstrates that using getList() will work in many area / servers.
github-actions
Bot
added
the
test native
Contributor
|
closing as this has been superseded by later PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstrates proposed spec changes
Implements getList() in the Spring Web MVC instrumentation's JakartaHttpServletRequestGetter.
Implements a test to demonstrate the new W3CBaggagePropagator working with multiple baggage headers (using a locally published version of opentelemetry-api and opentelemetry-context, which contains the changes to the textmapgetter interface and baggage propagator).
The TextMapGetter operates on a Jakarta servlet HttpServletRequest, a very common interface used in many servers. This demonstrates that using getList() should work in many area / servers.
The build will obviously not pass because it's relying on local SNAPSHOT changes that aren't merged to main in
opentelemetry-java