Implement forEach support for aws sqs tracing list#10062
Merged
Conversation
kenfinnigan
approved these changes
Dec 13, 2023
trask
approved these changes
Dec 13, 2023
elbiocaetano
pushed a commit
to elbiocaetano/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 19, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we only handle the
iteratormethod, this pr also adds handling for theforEachmethod. Similar change isn't needed for the kafka tracing list because it does not extendArrayListand the default implementation offorEachalready uses the iterator.