Capture http.route for akka-http#10039
Merged
Merged
Conversation
laurit
marked this pull request as ready for review
December 8, 2023 17:18
breedx-splk
approved these changes
Dec 8, 2023
breedx-splk
left a comment
breedx-splk
left a comment
Contributor
There was a problem hiding this comment.
This is really clever, nicely done!
…/opentelemetry/javaagent/instrumentation/akkahttp/server/route/PathMatcherInstrumentation.java Co-authored-by: jason plumb <[email protected]>
Member
|
nice |
|
Hi @laurit! Do you think this is backportable to the 1.x line? I can do the work needed. |
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
Co-authored-by: jason plumb <[email protected]>
Member
Member
|
@tomsfernandez can you send a PR against the #10777 PR branch to fix CI? looks like it needs some updates related to the new semconv changes |
samwright
added a commit
to samwright/opentelemetry-java-instrumentation
that referenced
this pull request
Mar 11, 2024
All credit goes to @laurit for doing this for akka in PR open-telemetry#10039. I'm just copying it for pekko (the open-source fork of akka).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When akka-http routing dsl (https://doc.akka.io/docs/akka-http/current/routing-dsl/index.html) is used we can construct
http.routeas the elements in the dsl are matched. We capture the matched textual elements and/and replace all other matched segments with*