Is your feature request related to a problem? Please describe.
SQSEvent handler lambdas can report partial batch failures by returning a SQSBatchResponse object containing a list of message ids which failed to be processed (to be put back in the queue). That means those handlers must implement RequestHandler<SQSEvent, SQSBatchResponse>.
The current OpenTelemetry SQS wrapper implements RequestHandler<SQSEvent, Void> instead.
Describe the solution you'd like
I believe we can change these two handlers:
|
public abstract class TracingSqsEventHandler extends TracingRequestHandler<SQSEvent, Void> { |
|
public class TracingSqsEventWrapper extends TracingSqsEventHandler { |
To implement TracingRequestHandler<SQSEvent, T> instead of TracingRequestHandler<SQSEvent, Void>.
Describe alternatives you've considered
No response
Additional context
No response
Tip
React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.
Is your feature request related to a problem? Please describe.
SQSEvent handler lambdas can report partial batch failures by returning a
SQSBatchResponseobject containing a list of message ids which failed to be processed (to be put back in the queue). That means those handlers must implementRequestHandler<SQSEvent, SQSBatchResponse>.The current OpenTelemetry SQS wrapper implements
RequestHandler<SQSEvent, Void>instead.Describe the solution you'd like
I believe we can change these two handlers:
opentelemetry-java-instrumentation/instrumentation/aws-lambda/aws-lambda-events-2.2/library/src/main/java/io/opentelemetry/instrumentation/awslambdaevents/v2_2/TracingSqsEventHandler.java
Line 17 in 394d053
opentelemetry-java-instrumentation/instrumentation/aws-lambda/aws-lambda-events-2.2/library/src/main/java/io/opentelemetry/instrumentation/awslambdaevents/v2_2/TracingSqsEventWrapper.java
Line 17 in 394d053
To implement
TracingRequestHandler<SQSEvent, T>instead ofTracingRequestHandler<SQSEvent, Void>.Describe alternatives you've considered
No response
Additional context
No response
Tip
React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding
+1orme too, to help us triage it. Learn more here.