[dynamic control] Align to name and ID in spec for policies#2926
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a dedicated identity value object for telemetry policies and documents how policy type/id/name are intended to be used in dynamic-control.
Changes:
- Introduces
TelemetryPolicyIdentity(id + name) with validation and value semantics (equals/hashCode/toString). - Expands dynamic-control README with guidance and examples for policy
type/id/nameusage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dynamic-control/src/main/java/io/opentelemetry/contrib/dynamic/policy/TelemetryPolicyIdentity.java | New identity/value object for policy instances with basic validation + equality semantics. |
| dynamic-control/README.md | Documentation clarifying policy type/id/name semantics with YAML/JSON examples. |
LikeTheSalad
approved these changes
Jun 18, 2026
25 tasks
jaydeluca
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Step 1 of aligning to the telemetry policy spec. Specifically policies had a name and ID. To keep reviewing easier, this PR adds only the identity class, unused, and the documentation. Future PRs will add the identity to the policies and provide tests
Existing Issue(s):
part of #2868
Testing:
Tests will be added when the identity is added to the policies in the next step
Documentation:
Added
Outstanding items:
The identity added here needs to be added to policies in the next step. Additionally see #2868 .