Handle NumberFormatException when parsing numbers#2880
Merged
jack-berg merged 2 commits intoJun 1, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves robustness of cloud resource detection by preventing NumberFormatException from bubbling up when parsing numeric metadata/environment values in the GCP Cloud Run Job and Azure Functions resource providers.
Changes:
- Catch
NumberFormatExceptionwhen parsing Cloud Run Job task index and Azure Functions memory limit, skipping the numeric attribute when malformed. - Add regression tests ensuring malformed numeric inputs do not set the corresponding attributes.
- Minor cleanup in
GCPResourceProviderTestto use static Mockito imports.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gcp-resources/src/main/java/io/opentelemetry/contrib/gcp/resource/GCPResourceProvider.java | Wrap Cloud Run Job task index parsing in try/catch and log on malformed values. |
| gcp-resources/src/test/java/io/opentelemetry/contrib/gcp/resource/GCPResourceProviderTest.java | Add test for malformed Cloud Run Job task index; refactor Mockito usage via static imports. |
| azure-resources/src/main/java/io/opentelemetry/contrib/azure/resource/AzureFunctionsResourceProvider.java | Wrap Azure Functions memory limit parsing in try/catch and log on malformed values. |
| azure-resources/src/test/java/io/opentelemetry/contrib/azure/resource/AzureFunctionsResourceProviderTest.java | Add test for malformed Azure Functions memory limit. |
jack-berg
force-pushed
the
guard-parselong-azure-functions
branch
from
May 28, 2026 13:03
237fb0a to
4931235
Compare
jaydeluca
approved these changes
May 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
May 28, 2026
zeitlinger
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.