[disk-buffering] Add guard for non-numeric files#2877
Merged
jaydeluca merged 3 commits intoMay 28, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the disk-buffering folder handling by preventing NumberFormatException when encountering non-numeric files in the cache directory, and improves error reporting when clear() can’t list directory contents.
Changes:
- Guard
purgeExpiredFilesIfAnyagainst non-numeric filenames to avoidLong.parseLong(...)failures. - Improve
clear()failure mode by throwing anIOExceptionwhenfolder.listFiles()returnsnull. - Add regression tests covering non-numeric files and the new
clear()error path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| disk-buffering/src/main/java/io/opentelemetry/contrib/disk/buffering/internal/storage/FolderManager.java | Adds filename guard during purge and improves clear() error handling when directory listing fails. |
| disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/internal/storage/FolderManagerTest.java | Adds tests ensuring non-numeric files don’t crash writes and that clear() throws a helpful IOException when the folder can’t be listed. |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
6 tasks
jack-berg
approved these changes
May 27, 2026
jaydeluca
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
purgeExpiredFilesIfAnywas callingLong.parseLong(...with no guard, which could throwNumberFormatExceptionfor non-numeric files. ThefileToCacheFilemethod already had a pattern check so made this method consistnt with that approach.Also a small update for the
clear()method, just adding a more descriptive error message instead of a generic NPE if a directory is unreachable.