Close leaky resources in azure-resources#2876
Merged
Merged
Conversation
github-actions
Bot
requested review from
breedx-splk,
dsgrieve,
jeanbisutti,
trask and
zeitlinger
May 27, 2026 19:34
jack-berg
marked this pull request as ready for review
May 27, 2026 19:34
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses resource-leak risks in two contrib components by ensuring streams/clients are properly closed after use.
Changes:
jfr-connection: read JFC configuration with try-with-resources and add error wrapping when reading fails.azure-resources: ensure OkHttp resources (dispatcher executor + connection pool) are shut down/evicted after each metadata fetch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
jfr-connection/src/main/java/io/opentelemetry/contrib/jfr/connection/JfcFileConfiguration.java |
Uses try-with-resources for configuration reading and adds exception wrapping. |
azure-resources/src/main/java/io/opentelemetry/contrib/azure/resource/AzureMetadataService.java |
Explicitly shuts down OkHttp client internals to prevent thread/connection leaks. |
jack-berg
changed the title
jaydeluca
approved these changes
May 27, 2026
trask
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.