Change ibm-mq-metrics to use snake yaml engine v2#2872
Merged
jaydeluca merged 4 commits intoMay 27, 2026
Conversation
atoulme
approved these changes
May 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ibm-mq-metrics to use SnakeYAML Engine v2 for YAML parsing, aligning with newer YAML tooling and reducing the risk of unsafe custom-tag behavior.
Changes:
- Replaced
org.yaml:snakeyamlwithorg.snakeyaml:snakeyaml-enginein the module dependencies. - Migrated
ConfigWrapper.parse(...)to SnakeYAML Engine v2’sLoadAPI. - Added a regression test asserting Java-type YAML tags are rejected.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
ibm-mq-metrics/src/main/java/io/opentelemetry/ibm/mq/opentelemetry/ConfigWrapper.java |
Switches YAML parsing implementation to SnakeYAML Engine v2 (Load / LoadSettings). |
ibm-mq-metrics/src/test/java/io/opentelemetry/ibm/mq/opentelemetry/ConfigWrapperTest.java |
Updates AssertJ imports and adds a test for rejecting custom Java-type YAML tags. |
ibm-mq-metrics/build.gradle.kts |
Replaces the SnakeYAML dependency with snakeyaml-engine. |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
This was referenced May 27, 2026
jaydeluca
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade ibm-mq-metrics to use snake yaml engine v2. In addition to this being the latest version of the library, and the same version used in opentelemetry-java for declarative config, it also removes the possibility of arbitrary java type instantiation using custom YAML tags since support for that feature was dropped.