[dynamic control] enable autoconfigurable extension#2866
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds dynamic policy initialization during OpenTelemetry auto-configuration and strengthens the corresponding unit test to validate customization behavior.
Changes:
- Invoke
PolicyInit.init(...)fromDynamicControlAutoConfiguration.customize(...). - Update
DynamicControlAutoConfigurationTestto verify a properties customizer is registered.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dynamic-control/src/main/java/io/opentelemetry/contrib/dynamic/DynamicControlAutoConfiguration.java | Initializes dynamic policy registry during agent auto-configuration. |
| dynamic-control/src/test/java/io/opentelemetry/contrib/dynamic/DynamicControlAutoConfigurationTest.java | Replaces “no-throw” comment with a Mockito verification of expected customization behavior. |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
LikeTheSalad
approved these changes
May 26, 2026
jaydeluca
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Initial Telemetry policy implementation is done with one policy supported (sampling rate changes), this enables the extension to be autoconfigurable
Existing Issue(s):
#2416
Testing:
Manually tested as working end-to-end with changes
Documentation:
To be added
Outstanding items:
see #2868