[dynamic control] add SourceFormat string to enum conversion#2737
Merged
jaydeluca merged 5 commits intoopen-telemetry:mainfrom Apr 2, 2026
Merged
[dynamic control] add SourceFormat string to enum conversion#2737jaydeluca merged 5 commits intoopen-telemetry:mainfrom
jaydeluca merged 5 commits intoopen-telemetry:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a SourceFormat.fromConfigValue() helper to convert config strings into SourceFormat enum values for dynamic-control config parsing.
Changes:
- Introduced
SourceFormat.fromConfigValue(String)with trimming + case-insensitive matching againstconfigValue() - Added unit tests covering case-insensitivity, whitespace trimming, and invalid inputs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| dynamic-control/src/main/java/io/opentelemetry/contrib/dynamic/policy/source/SourceFormat.java | Adds the string-to-enum conversion helper with normalization and validation. |
| dynamic-control/src/test/java/io/opentelemetry/contrib/dynamic/policy/source/SourceFormatTest.java | Adds tests validating parsing behavior and error handling for the new helper. |
…/policy/source/SourceFormat.java Co-authored-by: Copilot <[email protected]>
jackshirazi
commented
Apr 1, 2026
LikeTheSalad
approved these changes
Apr 2, 2026
jaydeluca
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Just SourceFormat.fromConfigValue() method to convert from string to enum, needed for parsing config
Existing Issue(s):
#2546
Testing:
added
Documentation:
added
Outstanding items:
the rest of the parsing is to come