[dynamic control] Move to using SourceWrapper, simplifying parsing#2708
Merged
jaydeluca merged 1 commit intoopen-telemetry:mainfrom Mar 23, 2026
Merged
[dynamic control] Move to using SourceWrapper, simplifying parsing#2708jaydeluca merged 1 commit intoopen-telemetry:mainfrom
jaydeluca merged 1 commit intoopen-telemetry:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the dynamic-control “Telemetry Policy” work by shifting LinePerPolicyFileProvider to parse input lines into SourceWrapper instances (via SourceFormat) and adding a new abstract validator base to centralize source-dispatch and common parsing helpers.
Changes:
- Update
LinePerPolicyFileProviderto parse each non-comment line usingSourceFormatand validate viaPolicyValidator#validate(SourceWrapper). - Add
AbstractSourcePolicyValidatorwith shared JSON/key-value dispatch and primitive parsing helpers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| dynamic-control/src/main/java/io/opentelemetry/contrib/dynamic/policy/LinePerPolicyFileProvider.java | Switches line parsing/validation to SourceFormat + SourceWrapper flow and updates provider Javadoc. |
| dynamic-control/src/main/java/io/opentelemetry/contrib/dynamic/policy/AbstractSourcePolicyValidator.java | Introduces a base validator for dispatching by source format and shared parsing helpers. |
LikeTheSalad
approved these changes
Mar 23, 2026
jaydeluca
approved these changes
Mar 23, 2026
Merged
via the queue into
open-telemetry:main
with commit Mar 23, 2026
73c7be1
24 of 25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Continuing the transition to simpler validation and adding an abstract validator to include utility validation methods concrete subclasses can use
Existing Issue(s):
#2546
Testing:
Already present but will be simpler along with simpler validation
Documentation:
docs will be updated after migration is complete
Outstanding items:
several more PRs to come to migrate from json to jsonkeyvalue and refactor of providers to simplify validation, I'm trying to keep the PRs as small as possible which means some duplication in the meantime until complete