[dynamic control] step 1 in transition to simpler validation#2703
Merged
trask merged 1 commit intoopen-telemetry:mainfrom Mar 20, 2026
Merged
[dynamic control] step 1 in transition to simpler validation#2703trask merged 1 commit intoopen-telemetry:mainfrom
trask merged 1 commit intoopen-telemetry:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a transitional validation entry-point that accepts parsed configuration sources to support the migration from JSON-only validation toward simpler validation flows (issue #2546).
Changes:
- Adds a default
validate(SourceWrapper)method toPolicyValidatorto validate parsed sources. - Bridges existing
validate(String)/validateAlias(String, String)logic forJsonSourceWrapperandKeyValueSourceWrapper.
You can also share your feedback on Copilot code review. Take the survey.
LikeTheSalad
approved these changes
Mar 20, 2026
trask
approved these changes
Mar 20, 2026
Merged
via the queue into
open-telemetry:main
with commit Mar 20, 2026
5075fa2
24 of 25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
first step in transitioning to to simpler validation
Existing Issue(s):
#2546
Testing:
Already present but will be simpler along with simpler validation
Documentation:
docs will be updated after migration is complete
Outstanding items:
several more PRs to come to migrate from json to jsonkeyvalue and refactor of providers to simplify validation, I'm trying to keep the PRs as small as possible which means some duplication in the meantime until complete