[dynamic control] add jsonkeyvalue source#2702
Merged
trask merged 2 commits intoopen-telemetry:mainfrom Mar 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit jsonkeyvalue source format option to begin migrating away from the generic json naming while keeping current parsing behavior.
Changes:
- Adds
JSONKEYVALUEtoSourceFormatenum with config valuejsonkeyvalue - Keeps current JSON parsing implementation by dispatching both
jsonandjsonkeyvalueto the same parser
You can also share your feedback on Copilot code review. Take the survey.
LikeTheSalad
approved these changes
Mar 20, 2026
trask
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
first step to being more explicit about the current source support which rather than generic json with generic mapping (which is possible), is json key-value, like {"some-key": "some-value"}
Existing Issue(s):
#2546
Testing:
Effectively the current json tests
Documentation:
docs will be updated after migration is complete
Outstanding items:
several more PRs to come to migrate from json to jsonkeyvalue and refactor providers, I'm trying to keep the PRs as small as possible which means some duplication in the meantime until complete