Fix/upstream update disk buffering#2694
Merged
trask merged 4 commits intoMar 16, 2026
Merged
Conversation
LikeTheSalad
commented
Mar 16, 2026
| * otel.sdk.metric_reader.collection.duration}) that {@link PeriodicMetricReader} automatically | ||
| * records, returning only metrics from the test's instrumentation scope. | ||
| */ | ||
| private static List<MetricData> filterTestMetrics(List<MetricData> metrics) { |
Contributor
Author
There was a problem hiding this comment.
This is needed after these changes: open-telemetry/opentelemetry-java#8038
Contributor
There was a problem hiding this comment.
Pull request overview
Updates disk-buffering to align with upstream OpenTelemetry changes, stabilizing integration tests and removing reliance on incubator APIs.
Changes:
- Filter metrics in
IntegrationTestto ignore upstream self-instrumentation metrics fromPeriodicMetricReader. - Remove incubator extended-attributes usage from
LogRecordDataImpland drop the incubator dependency. - Bump
otelInstrumentationVersionto2.26.0-alpha.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/IntegrationTest.java | Adjusts assertions by filtering out non-test metrics produced by upstream components. |
| disk-buffering/src/main/java/io/opentelemetry/contrib/disk/buffering/internal/serialization/mapping/logs/models/LogRecordDataImpl.java | Switches to stable LogRecordData and removes incubator extended attributes implementation. |
| disk-buffering/build.gradle.kts | Removes opentelemetry-api-incubator dependency now that incubator APIs aren’t used. |
| dependencyManagement/build.gradle.kts | Updates the managed instrumentation version to 2.26.0-alpha. |
You can also share your feedback on Copilot code review. Take the survey.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates disk-buffering and noop API to align with upstream OpenTelemetry changes, including handling of newly emitted self-instrumentation metrics and removal of incubator dependencies.
Changes:
- Bumped OpenTelemetry instrumentation BOM version to
2.26.0-alpha. - Updated disk-buffering integration tests to ignore SDK self-instrumentation metrics.
- Removed incubator extended-attributes usage from log record modeling and adjusted noop SpanBuilder attribute nullability.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| noop-api/src/main/java/io/opentelemetry/contrib/noopapi/NoopTracerProvider.java | Adjusts noop SpanBuilder attribute setters to accept nullable values. |
| disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/IntegrationTest.java | Filters out SDK self-metrics so integration assertions remain stable. |
| disk-buffering/src/main/java/io/opentelemetry/contrib/disk/buffering/internal/serialization/mapping/logs/models/LogRecordDataImpl.java | Migrates from incubator extended log record API to LogRecordData. |
| disk-buffering/build.gradle.kts | Removes incubator API dependency. |
| dependencyManagement/build.gradle.kts | Updates instrumentation version to 2.26.0-alpha. |
You can also share your feedback on Copilot code review. Take the survey.
LikeTheSalad
force-pushed
the
fix/upstream-update-disk-buffering
branch
from
March 16, 2026 15:59
02408ce to
0cdca1c
Compare
trask
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2690