initial TelemetryPolicy#2592
Merged
trask merged 4 commits intoopen-telemetry:mainfrom Feb 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an initial implementation of TelemetryPolicy based on the telemetry policy proposal. The implementation provides a foundational data structure for representing telemetry policies with a type identifier and JSON specification content.
Changes:
- Adds a new
TelemetryPolicyclass to represent telemetry policies with type and specification fields - Includes Jackson databind dependency for JSON handling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| dynamic-control/src/main/java/io/opentelemetry/contrib/dynamic/policy/TelemetryPolicy.java | Implements the core TelemetryPolicy class with type, spec fields, and standard Object methods |
| dynamic-control/build.gradle.kts | Adds Jackson databind dependency required for JSON handling |
trask
reviewed
Jan 30, 2026
| import java.util.Objects; | ||
| import javax.annotation.Nullable; | ||
|
|
||
| public class TelemetryPolicy { |
Member
There was a problem hiding this comment.
is this a public API? if so, can you add javadoc?
trask
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation of TelemetryPolicy per #2546.
A full working implementation of the telemetry policy proposal is here in this branch